Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(functions): add tem example #87

Merged
merged 3 commits into from
May 28, 2024
Merged

feat(functions): add tem example #87

merged 3 commits into from
May 28, 2024

Conversation

Bemilie
Copy link
Contributor

@Bemilie Bemilie commented May 23, 2024 •
edited
Loading

Summary

Add an example to send TEM from a serverless function.

Checklist

  • I have reviewed this myself.
  • I have attached a README to my example. You can use this template as reference.
  • I have updated the project README to link my example.

Details

The function was tested locally with scaleway_functions_python library. It was also deployed, and an email was sent successfully.

@Bemilie Bemilie self-assigned this May 23, 2024
@Bemilie Bemilie marked this pull request as ready for review May 23, 2024 16:16
@Bemilie Bemilie requested a review from cyclimse May 23, 2024 16:17
cyclimse
cyclimse approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@cyclimse cyclimse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Honestly, feel free to share it on the #tem channel, it's always nice to have product tutorials crossovers.

functions/python-tem-smtp-server/handler.py Outdated Show resolved Hide resolved
functions/python-tem-smtp-server/main.tf Outdated Show resolved Hide resolved
functions/python-tem-smtp-server/README.md Outdated Show resolved Hide resolved
@Bemilie Bemilie requested a review from Shillaker May 27, 2024 08:05
Shillaker
Shillaker approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@Shillaker Shillaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some small comments that I will leave you to implement.

README.md Outdated Show resolved Hide resolved
functions/python-tem-smtp-server/README.md Outdated Show resolved Hide resolved
functions/python-tem-smtp-server/README.md Outdated Show resolved Hide resolved
functions/python-tem-smtp-server/README.md Show resolved Hide resolved
@Bemilie Bemilie merged commit 81241ab into main May 28, 2024
8 checks passed
@Bemilie Bemilie deleted the feat/tem-example branch May 28, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyclimse cyclimse cyclimse approved these changes

@Shillaker Shillaker Shillaker approved these changes

Assignees

@Bemilie Bemilie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bemilie @Shillaker @cyclimse