Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): rework init command #835

Merged
merged 6 commits into from
Apr 3, 2020
Merged

feat(core): rework init command #835

merged 6 commits into from
Apr 3, 2020

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Apr 3, 2020 •
edited
Loading

Some examples:

Init all

Screenshot 2020-04-03 at 16 15 10

Autocomplete and SSH key already installed

Screenshot 2020-04-03 at 16 16 44

Cancel autocomplete install

Screenshot 2020-04-03 at 16 18 33

@jerome-quere
Copy link
Contributor

  • I would only print the message "An SSH key is ...." if we are going to ask him if he wants to upload an SSH key
  • I would not consider the key being already present and error an instead just print something like
Look like your local ssh key ~/.XXXX is already install on your scaleway account"

@QuentinBrosse
Copy link
Contributor Author

@jerome-quere I fully agree with you on these two points and I wanted to discuss it.

For the second point, we already do it for the autocomplete (not an error but a message) and we need to do it the ssh-key too for consistency.

@QuentinBrosse
Copy link
Contributor Author

@jerome-quere done (screenshots are updated)

jerome-quere
jerome-quere suggested changes Apr 3, 2020
View reviewed changes
internal/core/result.go Outdated Show resolved Hide resolved
jerome-quere
jerome-quere approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 29efee9 into scaleway:v2 Apr 3, 2020
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@jeansebastienh
test(rdb/Volume): Block storage for RDB is in beta only in WaW & AMS (s…
cfc6a86 
…caleway#835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuentinBrosse @jerome-quere @golangcibot