Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix autocomplete edge cases #811

Merged
merged 6 commits into from
Apr 23, 2020
Merged

fix(core): fix autocomplete edge cases #811

merged 6 commits into from
Apr 23, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Mar 26, 2020 •
edited
Loading

Fixes #810

  • a test is removed since it's never used in real world: autocompletion is only called once the command in typed and a space is added

Signed-off-by: Patrik Cyvoct [email protected]

@Sh4d1 Sh4d1 linked an issue Mar 26, 2020 that may be closed by this pull request
Autocomplete not working when using in shell functions or different binary name #810
Closed
@jerome-quere
Copy link
Contributor

Instead of replacing hardcoded scw by os.Args[0] it could be a better idea to make BinaryName a parameter in the BootstrapConfig this config could be accessible through context where needed

jerome-quere
jerome-quere suggested changes Apr 22, 2020
View reviewed changes
internal/core/autocomplete.go Outdated Show resolved Hide resolved
Sh4d1 and others added 5 commits April 22, 2020 19:28
@Sh4d1 @jerome-quere
fix(core): fix autocomplete edge cases
c2a3b04 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1 @jerome-quere
use os.Args instead of scw
49f8a70 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1 @jerome-quere
fix review
a72f394 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1 @jerome-quere
fix rebase
2a708df 
Signed-off-by: Patrik Cyvoct <[email protected]>
@jerome-quere
fix
10b8196
jerome-quere
jerome-quere approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sh4d1 Sh4d1 merged commit 8686ed2 into scaleway:v2 Apr 23, 2020
@Sh4d1 Sh4d1 mentioned this pull request Apr 24, 2020
Closed
@remyleone remyleone mentioned this pull request Apr 24, 2020
Closed
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@Sh4d1
feat(rdb): add volume_type and size to RDB instance (scaleway#811)
d72b0b9 
Signed-off-by: Patrik Cyvoct <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocomplete not working when using in shell functions or different binary name
2 participants
@Sh4d1 @jerome-quere