Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8s): add version commands #775

Merged
merged 8 commits into from
Mar 17, 2020
Merged

feat(k8s): add version commands #775

merged 8 commits into from
Mar 17, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Mar 14, 2020

Need the generated version commands first

Signed-off-by: Patrik Cyvoct [email protected]

loicbourgois
loicbourgois suggested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests please ?

At least :

  • a simple ok test, that uses a golden, so we can check what the output looks like
  • a test for each error, using TestCheckError: here we're interested in the error, not how it is presented

Sh4d1 and others added 8 commits March 17, 2020 15:30
@Sh4d1
feat(k8s): add version commands
d01ab9f 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
update goldens
5f352a8 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
add tests
fcae870 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1 @loicbourgois
Update internal/namespaces/k8s/v1beta4/custom_version_get.go
43deb82 
Co-Authored-By: Loïc Bourgois <[email protected]>
@Sh4d1 @loicbourgois
Update internal/namespaces/k8s/v1beta4/custom_version_get.go
15750b0 
Co-Authored-By: Loïc Bourgois <[email protected]>
@Sh4d1
fix reviews
17cd11a 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
fix goldn
ffa08fc 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
fix golden
0af715b 
Signed-off-by: Patrik Cyvoct <[email protected]>
loicbourgois
loicbourgois approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicbourgois loicbourgois merged commit edc16ed into scaleway:v2 Mar 17, 2020
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@remyleone
doc: Update instance_security_group.md (scaleway#775)
96511c8
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicbourgois loicbourgois loicbourgois approved these changes

Assignees
No one assigned
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sh4d1 @loicbourgois @remyleone