Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s): add version commands #775

Merged
merged 8 commits into from
Mar 17, 2020
Merged

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Mar 14, 2020

Need the generated version commands first

Signed-off-by: Patrik Cyvoct [email protected]

Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests please ?

At least :

  • a simple ok test, that uses a golden, so we can check what the output looks like
  • a test for each error, using TestCheckError: here we're interested in the error, not how it is presented

Sh4d1 and others added 8 commits March 17, 2020 15:30
Signed-off-by: Patrik Cyvoct <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicbourgois loicbourgois merged commit edc16ed into scaleway:v2 Mar 17, 2020
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants