Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve human marshal for nil value #737

Merged
merged 5 commits into from
Mar 2, 2020
Merged

chore: improve human marshal for nil value #737

merged 5 commits into from
Mar 2, 2020

Conversation

loicbourgois
Copy link
Contributor

No description provided.

@loicbourgois
Copy link
Contributor Author

Maybe we should use NA instead of - ?

kindermoumoute
kindermoumoute approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Concerning - or NA, I really prefer - or an empty string because NA is more likely to be used as an actual name.

@loicbourgois loicbourgois merged commit d08c4f9 into scaleway:v2 Mar 2, 2020
@loicbourgois loicbourgois deleted the APIGW-1958 branch March 2, 2020 15:52
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@remyleone
docs: remove the website folder (scaleway#737)
29f4fab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicbourgois @kindermoumoute