Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop [free|net]bsd support for go1.12+ #570

Merged
merged 2 commits into from
Sep 10, 2019
Merged

fix: drop [free|net]bsd support for go1.12+ #570

merged 2 commits into from
Sep 10, 2019

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Sep 9, 2019 •
edited
Loading

Drop the FreeBSD and NetBSD support for go1.12+ due to moby/moby#38818

You can still build them by yourself with Go 1.11:

$ go version
go version go1.11.13 darwin/amd64

$ make prepare-release-dist && cd dist/latest/
[...]

@QuentinBrosse QuentinBrosse force-pushed the fix-freebsd branch 2 times, most recently from c1121d2 to 261b3a9 Compare September 10, 2019 09:46
@QuentinBrosse QuentinBrosse changed the title fix: drop freebsd support for go1.12+ fix: drop [free|net]bsd support for go1.12+ Sep 10, 2019
jerome-quere
jerome-quere approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 5038e77 into scaleway:master Sep 10, 2019
@QuentinBrosse QuentinBrosse deleted the fix-freebsd branch November 13, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuentinBrosse @jerome-quere