Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): wait for volumes to be available before deletion #4388

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 27, 2024

No description provided.

@Codelax Codelax added bug instance Instance issues, bugs and feature requests labels Dec 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (5bf53e0) to head (0930cf2).
Report is 418 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4388      +/-   ##
==========================================
- Coverage   75.45%   70.69%   -4.76%     
==========================================
  Files         202      297      +95     
  Lines       44323    65873   +21550     
==========================================
+ Hits        33444    46570   +13126     
- Misses       9653    17661    +8008     
- Partials     1226     1642     +416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Dec 27, 2024
Merged via the queue into scaleway:master with commit 3cf1e63 Dec 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants