Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: image list with zone=all #4382

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Fix: image list with zone=all #4382

merged 2 commits into from
Dec 26, 2024

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@remyleone remyleone marked this pull request as ready for review December 26, 2024 11:24
@remyleone remyleone requested a review from Codelax as a code owner December 26, 2024 11:24
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Dec 26, 2024
@remyleone remyleone linked an issue Dec 26, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.83%. Comparing base (5bf53e0) to head (8985027).
Report is 412 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/custom_image.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4382      +/-   ##
==========================================
- Coverage   75.45%   70.83%   -4.62%     
==========================================
  Files         202      296      +94     
  Lines       44323    65737   +21414     
==========================================
+ Hits        33444    46566   +13122     
- Misses       9653    17529    +7876     
- Partials     1226     1642     +416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Dec 26, 2024
Merged via the queue into scaleway:master with commit 0686b22 Dec 26, 2024
13 checks passed
@remyleone remyleone deleted the image_list branch December 26, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instance image list zone=all does not work
3 participants