Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): handle sbs volumes in server backup #4248

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Oct 31, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Oct 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (5bf53e0) to head (519c04b).
Report is 340 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/custom_image.go 77.50% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4248      +/-   ##
==========================================
- Coverage   75.45%   70.99%   -4.46%     
==========================================
  Files         202      294      +92     
  Lines       44323    66011   +21688     
==========================================
+ Hits        33444    46866   +13422     
- Misses       9653    17505    +7852     
- Partials     1226     1640     +414     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added the priority:high New features label Nov 12, 2024
@Codelax Codelax force-pushed the fix/instance-server-backup-sbs branch from 23115b2 to 2bac975 Compare November 13, 2024 13:26
@Codelax Codelax marked this pull request as ready for review November 13, 2024 14:04
@remyleone remyleone added this pull request to the merge queue Nov 14, 2024
Merged via the queue into scaleway:master with commit c345fba Nov 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests priority:high New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants