Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): cannot create server with project-id #4127

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

ziirish
Copy link
Contributor

@ziirish ziirish commented Sep 12, 2024

While creating a server with a specific project-id, the request fail at the IP creation step.
This is because we provide both a project and an organization while only one of these is expected. We end up with the following error:

  Error while creating your public IP: scaleway-sdk-go: invalid argument(s):  does not respect constraint, Must contain one of ['organization', 'project']

This patch only provides a project since the organization field is deprecated.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

fix(instance): cannot create server with project-id

@ziirish ziirish requested a review from Codelax as a code owner September 12, 2024 16:51
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.44%. Comparing base (5bf53e0) to head (34fa022).
Report is 255 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4127      +/-   ##
==========================================
- Coverage   75.45%   72.44%   -3.01%     
==========================================
  Files         202      289      +87     
  Lines       44323    53951    +9628     
==========================================
+ Hits        33444    39086    +5642     
- Misses       9653    13263    +3610     
- Partials     1226     1602     +376     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

While creating a server with a specific project-id, the request fail at
the IP creation step.
This is because we provide both a project and an organization while only
one of these is expected. We end up with the following error:

  Error while creating your public IP: scaleway-sdk-go: invalid argument(s):  does not respect constraint, Must contain one of ['organization', 'project']

This patch only provides a project since the organization field is
deprecated.
@remyleone remyleone enabled auto-merge September 13, 2024 09:05
@remyleone remyleone added this pull request to the merge queue Sep 13, 2024
Merged via the queue into scaleway:master with commit 57298fc Sep 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants