Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): support sbs volumes in server creation #3968

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jul 9, 2024

No description provided.

@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Jul 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 82.43243% with 13 lines in your changes missing coverage. Please review.

Project coverage is 69.34%. Comparing base (5bf53e0) to head (0a4de4d).
Report is 272 commits behind head on master.

Files with missing lines Patch % Lines
...nal/namespaces/instance/v1/custom_server_create.go 75.55% 8 Missing and 3 partials ⚠️
...spaces/instance/v1/custom_server_create_builder.go 93.10% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (0a4de4d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (0a4de4d)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3968      +/-   ##
==========================================
- Coverage   75.45%   69.34%   -6.12%     
==========================================
  Files         202      291      +89     
  Lines       44323    55208   +10885     
==========================================
+ Hits        33444    38284    +4840     
- Misses       9653    15355    +5702     
- Partials     1226     1569     +343     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review July 10, 2024 09:18
@Codelax Codelax requested a review from remyleone as a code owner July 10, 2024 09:18
@remyleone remyleone enabled auto-merge July 10, 2024 09:22
@remyleone remyleone added this pull request to the merge queue Jul 10, 2024
Merged via the queue into scaleway:master with commit c843b60 Jul 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants