fix(inference): fix endpoint nil pointer create deployment #3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3922 +/- ##
==========================================
- Coverage 75.45% 69.24% -6.21%
==========================================
Files 202 290 +88
Lines 44323 55121 +10798
==========================================
+ Hits 33444 38169 +4725
- Misses 9653 15380 +5727
- Partials 1226 1572 +346 ☔ View full report in Codecov by Sentry. |
remyleone
reviewed
Jul 1, 2024
| @@ -96,7 +96,7 @@ func deploymentCreateBuilder(c *core.Command) *core.Command { | |||
| publicEndpoint = nil | |||
| } | |||
| privateNetwork := &inference.EndpointSpecPrivateNetwork{} | |||
| if endpoint.EndpointSpec == nil { | |||
| if endpoint.EndpointSpec.PrivateNetwork == nil { | |||
There was a problem hiding this comment.
What if endpoint.EndpointSpec is already nil?
There was a problem hiding this comment.
It creates a public endpoint.
remyleone
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3921