Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dedibox): set default value project-id #3916

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

Laure-di
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Laure-di Laure-di requested a review from remyleone as a code owner June 27, 2024 09:20
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 69.18%. Comparing base (5bf53e0) to head (ed4a1ce).
Report is 123 commits behind head on master.

Files Patch % Lines
internal/namespaces/dedibox/v1/custom.go 0.00% 30 Missing ⚠️
internal/core/context.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (ed4a1ce). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (5bf53e0) | HEAD (ed4a1ce) | |------|------|------| ||2|1|
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
- Coverage   75.45%   69.18%   -6.27%     
==========================================
  Files         202      288      +86     
  Lines       44323    54560   +10237     
==========================================
+ Hits        33444    37750    +4306     
- Misses       9653    15276    +5623     
- Partials     1226     1534     +308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

remyleone
remyleone previously approved these changes Jun 27, 2024
@remyleone remyleone added this pull request to the merge queue Jun 27, 2024
@remyleone remyleone removed this pull request from the merge queue due to a manual request Jun 27, 2024
@Laure-di Laure-di dismissed remyleone’s stale review June 27, 2024 13:10

The merge-base changed after approval.

@remyleone remyleone enabled auto-merge June 27, 2024 13:16
@remyleone remyleone added this pull request to the merge queue Jun 27, 2024
Merged via the queue into scaleway:master with commit 325f5a1 Jun 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants