Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apple_silicon): remove of cli's default value of type in CreateServerRequest #3794

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix(apple_silicon): remove of cli's default value of type in CreateServerRequest #3794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-apple-silicon-server-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ USAGE:
ARGS:
[name=<generated>] Create a server with this given name
[project-id] Project ID to use. If none is passed the default project ID will be used
[type=M1-M] Create a server of the given type
[type] Create a server of the given type
[os-id] Create a server with the given os_id
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-3)

Expand Down
2 changes: 1 addition & 1 deletion docs/commands/apple-silicon.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ scw apple-silicon server create [arg=value ...]
|------|---|-------------|
| name | Default: `<generated>` | Create a server with this given name |
| project-id | | Project ID to use. If none is passed the default project ID will be used |
| type | Default: `M1-M` | Create a server of the given type |
| type | | Create a server of the given type |
| os-id | | Create a server with the given os_id |
| zone | Default: `fr-par-1`<br />One of: `fr-par-3` | Zone to target. If none is passed will use default zone from the config |

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ require (
github.com/mattn/go-isatty v0.0.20
github.com/moby/buildkit v0.13.2
github.com/opencontainers/go-digest v1.0.0
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.26.0.20240425141551-6d81bfd0f8ad
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.26.0.20240425150324-84e93b73daba
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.8.0
github.com/spf13/pflag v1.0.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,8 +451,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.26.0.20240425141551-6d81bfd0f8ad h1:M/EeToOFlCAegAHFNC3EFNu7P7vqQrK6vLaigi3y1Ew=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.26.0.20240425141551-6d81bfd0f8ad/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.26.0.20240425150324-84e93b73daba h1:LD4AyBgbVcm0mqMdQ6xXBrPEwzUYJhkO4+PjHT+pZRM=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.26.0.20240425150324-84e93b73daba/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=
Expand Down
1 change: 0 additions & 1 deletion internal/namespaces/applesilicon/v1alpha1/applesilicon_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ func appleSiliconServerCreate() *core.Command {
Required: false,
Deprecated: false,
Positional: false,
Default: core.DefaultValueSetter("M1-M"),
},
{
Name: "os-id",
Expand Down
Loading