fix(instance): show unknown server-type availability when missing #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3760 +/- ##
==========================================
+ Coverage 75.45% 77.26% +1.80%
==========================================
Files 202 204 +2
Lines 44323 37363 -6960
==========================================
- Hits 33444 28868 -4576
+ Misses 9653 7256 -2397
- Partials 1226 1239 +13 ☔ View full report in Codecov by Sentry. |
remyleone
approved these changes
Apr 11, 2024
jremy42
pushed a commit
to jremy42/scaleway-cli
that referenced
this pull request
Apr 12, 2024
Laure-di
pushed a commit
to Laure-di/scaleway-cli
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3752
Default to unknown availability if API response miss a server-type. API seems to be a bit random using this route.