Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis): cluster list crash #3687

Merged
merged 9 commits into from
Mar 14, 2024

Conversation

Laure-di
Copy link
Contributor

close #3685

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.58%. Comparing base (127f1ab) to head (557dea6).
Report is 293 commits behind head on master.

Files with missing lines Patch % Lines
internal/human/specs.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3687   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files         196      196           
  Lines       43417    43417           
=======================================
  Hits        32818    32818           
  Misses       9395     9395           
  Partials     1204     1204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di marked this pull request as ready for review February 28, 2024 12:56
@Codelax
Copy link
Member

Codelax commented Feb 29, 2024

Still crash in another case

❯ scw redis endpoint get 18a0f371-0fa7-412d-a73d-ea85cb96ae3a   
---------------------------------------------------------------------------------------
An error occurred, we are sorry, please consider opening a ticket on github using: 'scw feedback bug'
Give us as many details as possible so we can reproduce the error and fix it.
---------------------------------------------------------------------------------------
interface conversion: interface {} is redis.Endpoint, not []*redis.Endpoint
stacktrace from panic: 
goroutine 1 [running]:
runtime/debug.Stack()
	/usr/local/go/src/runtime/debug/stack.go:24 +0x5e
main.cleanup(0xc0002d8460)
	/home/julescasteran/Documents/devtools/scaleway-cli/cmd/scw/main.go:42 +0xca
panic({0x17620c0?, 0xc000727230?})
	/usr/local/go/src/runtime/panic.go:914 +0x21f
github.com/scaleway/scaleway-cli/v2/internal/namespaces/redis/v1.redisEndpointsClusterGetMarshalerFunc({0x18bdde0?, 0xc0000d3240?}, 0x18bdde0?)
	/home/julescasteran/Documents/devtools/scaleway-cli/internal/namespaces/redis/v1/custom_cluster.go:164 +0x1db
github.com/scaleway/scaleway-cli/v2/internal/human.Marshal({0x18bdde0, 0xc0000d3240}, 0x1761d40?)
	/home/julescasteran/Documents/devtools/scaleway-cli/internal/human/marshal.go:61 +0x4db
github.com/scaleway/scaleway-cli/v2/internal/human.Marshal({0x16717c0, 0xc000677000}, 0xc000677000?)
	/home/julescasteran/Documents/devtools/scaleway-cli/internal/human/marshal.go:77 +0x392
github.com/scaleway/scaleway-cli/v2/internal/core.(*Printer).printHuman(0xc00015ccc0, {0x16717c0, 0xc000677000}, 0x0)
	/home/julescasteran/Documents/devtools/scaleway-cli/internal/core/printer.go:202 +0x198
github.com/scaleway/scaleway-cli/v2/internal/core.(*Printer).Print(0xc00015ccc0, {0x16717c0?, 0xc000677000?}, 0x199edc7?)
	/home/julescasteran/Documents/devtools/scaleway-cli/internal/core/printer.go:159 +0xef
github.com/scaleway/scaleway-cli/v2/internal/core.Bootstrap(0xc000b91e78)
	/home/julescasteran/Documents/devtools/scaleway-cli/internal/core/bootstrap.go:281 +0x156a
main.main()
	/home/julescasteran/Documents/devtools/scaleway-cli/cmd/scw/main.go:74 +0x33f


@Laure-di Laure-di marked this pull request as draft February 29, 2024 09:37
@Laure-di Laure-di marked this pull request as ready for review February 29, 2024 10:47
internal/namespaces/redis/v1/custom_cluster.go Outdated Show resolved Hide resolved
internal/namespaces/redis/v1/custom_cluster.go Outdated Show resolved Hide resolved
internal/namespaces/redis/v1/custom.go Outdated Show resolved Hide resolved
@Laure-di Laure-di marked this pull request as draft February 29, 2024 13:31
@Laure-di Laure-di force-pushed the fix/cluster-list-crash branch 2 times, most recently from 529c386 to 585796d Compare February 29, 2024 14:22
@Laure-di Laure-di marked this pull request as ready for review March 4, 2024 09:47
@remyleone remyleone added this pull request to the merge queue Mar 14, 2024
Merged via the queue into scaleway:master with commit b3c24a0 Mar 14, 2024
12 checks passed
jremy42 pushed a commit to jremy42/scaleway-cli that referenced this pull request Apr 3, 2024
Co-authored-by: Jules Castéran <[email protected]>
Co-authored-by: Jules Casteran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis: cluster list crash
4 participants