feat(mnq): add a create-context nats custom command #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
reviewed
Feb 12, 2024
| { | ||
| Name: "credentials-name", | ||
| Short: "Name of the created credentials", | ||
| Default: core.RandomValueGenerator("mnq"), |
There was a problem hiding this comment.
Could you make sure that both files have matching names.
| return nil | ||
| } | ||
|
|
||
| func extractFileName(path string, ext string) string { |
There was a problem hiding this comment.
Could filepath.Base() work ? Could you change the name?
Codelax
reviewed
Feb 13, 2024
jremy42
force-pushed
the
feat/mnq-nats-context-create-v2
branch
9 times, most recently
from
bfad3af
to
6ec015e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3655 +/- ##
==========================================
- Coverage 75.98% 75.87% -0.12%
==========================================
Files 184 189 +5
Lines 41494 42597 +1103
==========================================
+ Hits 31530 32319 +789
- Misses 8815 9091 +276
- Partials 1149 1187 +38 ☔ View full report in Codecov by Sentry. |
jremy42
force-pushed
the
feat/mnq-nats-context-create-v2
branch
4 times, most recently
from
9236ac0
to
0532e98
Compare
jremy42
force-pushed
the
feat/mnq-nats-context-create-v2
branch
from
0532e98
to
588fe1f
Compare
remyleone
changed the title
remyleone
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: