Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mnq): add a create-context nats custom command #3655

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Feb 12, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


{
Name: "credentials-name",
Short: "Name of the created credentials",
Default: core.RandomValueGenerator("mnq"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make sure that both files have matching names.

internal/namespaces/mnq/v1beta1/custom_nats_helpers.go Outdated Show resolved Hide resolved
internal/namespaces/mnq/v1beta1/custom_nats_helpers.go Outdated Show resolved Hide resolved
internal/namespaces/mnq/v1beta1/custom_nats_helpers.go Outdated Show resolved Hide resolved
internal/namespaces/mnq/v1beta1/custom_nats_test.go Outdated Show resolved Hide resolved
return nil
}

func extractFileName(path string, ext string) string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could filepath.Base() work ? Could you change the name?

@jremy42 jremy42 force-pushed the feat/mnq-nats-context-create-v2 branch 9 times, most recently from bfad3af to 6ec015e Compare February 19, 2024 14:05
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (c39deda) 75.98% compared to head (e097c1a) 75.87%.

Files Patch % Lines
...rnal/namespaces/mnq/v1beta1/custom_nats_helpers.go 56.70% 33 Missing and 9 partials ⚠️
...ernal/namespaces/mnq/v1beta1/custom_nats_prompt.go 10.81% 32 Missing and 1 partial ⚠️
internal/namespaces/mnq/v1beta1/custom_nats.go 85.48% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3655      +/-   ##
==========================================
- Coverage   75.98%   75.87%   -0.12%     
==========================================
  Files         184      189       +5     
  Lines       41494    42597    +1103     
==========================================
+ Hits        31530    32319     +789     
- Misses       8815     9091     +276     
- Partials     1149     1187      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 force-pushed the feat/mnq-nats-context-create-v2 branch 4 times, most recently from 9236ac0 to 0532e98 Compare February 19, 2024 15:33
@jremy42 jremy42 force-pushed the feat/mnq-nats-context-create-v2 branch from 0532e98 to 588fe1f Compare February 19, 2024 15:41
@remyleone remyleone changed the title Feat/mnq nats context create feat(mnq): add a create-context nats custom command Feb 20, 2024
@remyleone remyleone added this pull request to the merge queue Feb 20, 2024
Merged via the queue into scaleway:master with commit 17055b4 Feb 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants