Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rdb): acl set simplified [UI breaking-change] #3597

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Jan 12, 2024

Closes #3596
UI breaking change

Needs #3722 first

TODO:

  • add the customization of the description in set command
  • modify it in add/delete commands since arguments can be handled together.
    --> belongs in a separate PR

@Mia-Cross Mia-Cross added enhancement rdb Managed MySQL and PostgreSQL issues, bugs and feature requests labels Jan 12, 2024
@Mia-Cross Mia-Cross self-assigned this Jan 12, 2024
@remyleone remyleone added the priority:medium Improvements that are not the main priority label Jan 26, 2024
@remyleone remyleone assigned jremy42 and unassigned Mia-Cross Mar 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.24%. Comparing base (5bf53e0) to head (684ac98).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3597      +/-   ##
==========================================
+ Coverage   75.45%   77.24%   +1.78%     
==========================================
  Files         202      204       +2     
  Lines       44323    37303    -7020     
==========================================
- Hits        33444    28814    -4630     
+ Misses       9653     7255    -2398     
- Partials     1226     1234       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross changed the title Rdb acl set simplified feat(rdb): acl set simplified Mar 21, 2024
@Mia-Cross Mia-Cross changed the title feat(rdb): acl set simplified feat(rdb): acl set simplified [UI breaking-change] Apr 10, 2024
@Mia-Cross Mia-Cross marked this pull request as ready for review April 10, 2024 12:12
@remyleone remyleone added this pull request to the merge queue Apr 10, 2024
Merged via the queue into scaleway:master with commit 0d06554 Apr 10, 2024
12 checks passed
@Mia-Cross Mia-Cross deleted the rdb_acl_set_simplified branch April 10, 2024 13:08
@Mia-Cross Mia-Cross restored the rdb_acl_set_simplified branch April 10, 2024 13:08
@Mia-Cross Mia-Cross deleted the rdb_acl_set_simplified branch April 10, 2024 13:08
jremy42 pushed a commit to jremy42/scaleway-cli that referenced this pull request Apr 12, 2024
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority:medium Improvements that are not the main priority rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rdb: simplify ACL handling for set
4 participants