Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): add volume wait command #3526

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 6, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Dec 6, 2023
@Codelax Codelax self-assigned this Dec 6, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d77d758) 75.86% compared to head (4ded8a4) 75.85%.

Files Patch % Lines
internal/namespaces/instance/v1/custom_volume.go 47.36% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3526      +/-   ##
==========================================
- Coverage   75.86%   75.85%   -0.02%     
==========================================
  Files         178      178              
  Lines       40426    40448      +22     
==========================================
+ Hits        30670    30682      +12     
- Misses       8653     8662       +9     
- Partials     1103     1104       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Dec 6, 2023
Merged via the queue into scaleway:master with commit fc2e030 Dec 6, 2023
12 checks passed
@Codelax Codelax deleted the feat/instance-volume-wait branch December 6, 2023 13:24
Mia-Cross pushed a commit to Mia-Cross/scaleway-cli that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants