Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rdb): print messages while exporting backup #3479

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

Mia-Cross
Copy link
Contributor

Closes #1434

The feature was already implemented by @yfodil, this PR just adds a message to inform the user that the backup is being exported.

@Mia-Cross Mia-Cross added rdb Managed MySQL and PostgreSQL issues, bugs and feature requests priority:high New features labels Nov 8, 2023
@Mia-Cross Mia-Cross self-assigned this Nov 8, 2023
@Mia-Cross Mia-Cross marked this pull request as ready for review November 9, 2023 12:48
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (dc6469d) 75.67% compared to head (e8a9ebc) 75.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3479      +/-   ##
==========================================
- Coverage   75.67%   75.66%   -0.01%     
==========================================
  Files         175      175              
  Lines       39087    39098      +11     
==========================================
+ Hits        29579    29584       +5     
- Misses       8433     8437       +4     
- Partials     1075     1077       +2     
Files Coverage Δ
internal/namespaces/rdb/v1/custom_backup.go 79.48% <50.00%> (-1.43%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross force-pushed the rdb_autoexport_backup branch 2 times, most recently from 411ca20 to 554d60c Compare November 10, 2023 13:58
@remyleone remyleone added this pull request to the merge queue Nov 10, 2023
Merged via the queue into scaleway:master with commit 273cd30 Nov 10, 2023
12 checks passed
@Mia-Cross Mia-Cross deleted the rdb_autoexport_backup branch November 10, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high New features rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoexport a backup in case it is not present
3 participants