Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vpc): add k8s view on get private-network + goconst lint #3456

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Oct 26, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@yfodil yfodil added bug vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Oct 26, 2023
@yfodil yfodil self-assigned this Oct 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87790e2) 75.65% compared to head (3528204) 75.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3456   +/-   ##
=======================================
  Coverage   75.65%   75.65%           
=======================================
  Files         175      175           
  Lines       39030    39035    +5     
=======================================
+ Hits        29528    29533    +5     
  Misses       8429     8429           
  Partials     1073     1073           
Files Coverage Δ
...ternal/namespaces/vpc/v2/custom_private_network.go 70.43% <100.00%> (+0.49%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yfodil yfodil changed the title fix(vpc): add k8s view on get private-network fix(vpc): add k8s view on get private-network + goconst lint Oct 26, 2023
@remyleone remyleone added this pull request to the merge queue Oct 30, 2023
Merged via the queue into scaleway:master with commit 95bdee6 Oct 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants