Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User agent #273

Merged
merged 2 commits into from
Jan 28, 2016
Merged

User agent #273

merged 2 commits into from
Jan 28, 2016

Conversation

QuentinPerez
Copy link
Contributor

houndci-bot
houndci-bot reviewed Jan 28, 2016
View reviewed changes
contrib/builder/homebrew/scw.rb
@@ -24,8 +20,7 @@ def install
ln_s buildpath, buildpath/"src/github.com/scaleway/scaleway-cli"
Language::Go.stage_deps resources, buildpath/"src"

version = `cat .goxc.json | grep "PackageVersion" | egrep -o "([0-9]{1,}\.)+[0-9]{1,}"`
system "go", "build", "-ldflags", "-X github.com/scaleway/scaleway-cli/pkg/scwversion.GITCOMMIT=homebrew -X github.com/scaleway/scaleway-cli/pkg/scwversion.VERSION=#{version}", "./cmd/scw"
system "go", "build", "-ldflags", "-X github.com/scaleway/scaleway-cli/pkg/scwversion.GITCOMMIT=homebrew", "./cmd/scw"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [123/80]

@moul
Copy link
Contributor

moul commented Jan 28, 2016

LGTM

moul added a commit that referenced this pull request Jan 28, 2016
@moul
Merge pull request #273 from QuentinPerez/userAgent
eea4fb4 
User agent
@moul moul merged commit eea4fb4 into scaleway:master Jan 28, 2016
@moul moul removed the in progress label Jan 28, 2016
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@kindermoumoute
doc: add sg example with for_each (scaleway#273)
078886a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuentinPerez @moul @houndci-bot