Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lb): improve backend help in case healthcheck is missing #2689

Merged
merged 6 commits into from
Nov 29, 2023
Merged

feat(lb): improve backend help in case healthcheck is missing #2689

merged 6 commits into from
Nov 29, 2023

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Dec 22, 2022

No description provided.

@yfodil yfodil added enhancement load-balancer Load-balancer issues, bugs and feature requests labels Dec 22, 2022
@yfodil yfodil self-assigned this Dec 22, 2022
@yfodil yfodil linked an issue Dec 22, 2022 that may be closed by this pull request
Improve help for backend creation in case healthcheck is missing #1281
Closed
quantumsheep
quantumsheep requested changes Dec 23, 2022
View reviewed changes
internal/namespaces/lb/v1/custom_backend.go Outdated Show resolved Hide resolved
internal/namespaces/lb/v1/custom_backend.go Outdated Show resolved Hide resolved
internal/namespaces/lb/v1/custom_backend.go Outdated Show resolved Hide resolved
@remyleone remyleone added the priority:high New features label Jan 25, 2023
@yfodil yfodil added this pull request to the merge queue Nov 29, 2023
Merged via the queue into scaleway:master with commit ea6fdae Nov 29, 2023
12 checks passed
@yfodil yfodil deleted the feat/improve_lb_backend_error_message branch November 29, 2023 13:45
Mia-Cross pushed a commit to Mia-Cross/scaleway-cli that referenced this pull request Dec 27, 2023
@yfodil @remyleone @Mia-Cross
feat(lb): improve backend help in case healthcheck is missing (scalew…
343cde6 
…ay#2689)

Co-authored-by: Rémy Léone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantumsheep quantumsheep quantumsheep approved these changes

Assignees

@yfodil yfodil

Labels
enhancement load-balancer Load-balancer issues, bugs and feature requests priority:high New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve help for backend creation in case healthcheck is missing
3 participants
@yfodil @quantumsheep @remyleone