Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lb): add first to ForwardPortAlgorithm enum #1467

Merged
merged 1 commit into from
Oct 12, 2020
Merged

feat(lb): add first to ForwardPortAlgorithm enum #1467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-lb-backend-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ARGS:
name=<generated> Resource name
forward-protocol Backend protocol. TCP or HTTP (tcp | http)
forward-port User sessions will be forwarded to this port of backend servers
forward-port-algorithm=roundrobin Load balancing algorithm (roundrobin | leastconn)
forward-port-algorithm=roundrobin Load balancing algorithm (roundrobin | leastconn | first)
sticky-sessions=none Enables cookie-based session persistence (none | cookie | table)
[sticky-sessions-cookie-name] Cookie name for for sticky sessions
[health-check.mysql-config.user]
Expand Down
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-lb-backend-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ARGS:
[name]
[forward-protocol] (tcp | http)
[forward-port]
[forward-port-algorithm] (roundrobin | leastconn)
[forward-port-algorithm] (roundrobin | leastconn | first)
[sticky-sessions] (none | cookie | table)
[sticky-sessions-cookie-name]
[timeout-server]
Expand Down
4 changes: 2 additions & 2 deletions internal/namespaces/lb/v1/lb_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ func lbBackendCreate() *core.Command {
Deprecated: false,
Positional: false,
Default: core.DefaultValueSetter("roundrobin"),
EnumValues: []string{"roundrobin", "leastconn"},
EnumValues: []string{"roundrobin", "leastconn", "first"},
},
{
Name: "sticky-sessions",
Expand Down Expand Up @@ -931,7 +931,7 @@ func lbBackendUpdate() *core.Command {
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"roundrobin", "leastconn"},
EnumValues: []string{"roundrobin", "leastconn", "first"},
},
{
Name: "sticky-sessions",
Expand Down