Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init): save project_id in config #1380

Merged
merged 4 commits into from
Sep 3, 2020
Merged

Conversation

QuentinBrosse
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Save the `project_id` in the config with the `scw init` command

jerome-quere
jerome-quere previously approved these changes Sep 3, 2020
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

remyleone
remyleone previously approved these changes Sep 3, 2020
@jerome-quere
Copy link
Contributor

Do we have test for init ? Should we add a test for this ?

@QuentinBrosse
Copy link
Contributor Author

Do we have test for init ? Should we add a test for this?

@jerome-quere in this precise use-case it's complex to test as we need to test the behavior where the scw init will automatically get the access_key, organization_id, project_id, ... from the account API. It will require to moke the account API but without cassettes to get a consistent result and test this result.
I think that's why we only check the secret_key in the "Override" test.

Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 97c5e2e into master Sep 3, 2020
@remyleone remyleone deleted the init-project-id branch October 1, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants