Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8s): add support for showing pools in get cluster #1311

Merged
merged 2 commits into from
Jul 31, 2020
Merged

feat(k8s): add support for showing pools in get cluster #1311

merged 2 commits into from
Jul 31, 2020

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@remyleone remyleone marked this pull request as draft July 30, 2020 09:38
@remyleone remyleone linked an issue Jul 30, 2020 that may be closed by this pull request
When getting a k8s cluster il would like to see the pools #1202
Closed
@remyleone remyleone self-assigned this Jul 30, 2020
@remyleone remyleone marked this pull request as ready for review July 30, 2020 12:07
Sh4d1
Sh4d1 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 45018f1 into scaleway:master Jul 31, 2020
@remyleone remyleone deleted the pool_in_get_cluster branch July 31, 2020 08:25
remyleone
remyleone commented Oct 14, 2020
View reviewed changes
internal/namespaces/k8s/v1/testdata/test-get-cluster-simple.golden
"feature_gates": [],
"admission_plugins": []
}
"ID b431a5b7-98f3-42fe-870d-b404dfff90f7\nName cli-test\nStatus creating\nVersion 1.17.3\nRegion fr-par\nOrganizationID 951df375-e094-4d26-97c1-ba548eeb9c42\nCni cilium\nDescription -\nClusterURL https://b431a5b7-98f3-42fe-870d-b404dfff90f7.api.k8s.fr-par.scw.cloud:6443\nDNSWildcard *.b431a5b7-98f3-42fe-870d-b404dfff90f7.nodes.k8s.fr-par.scw.cloud\nCreatedAt few seconds ago\nUpdatedAt few seconds ago\nDashboardEnabled false\nIngress none\nUpgradeAvailable true\n\nAutoscaler configuration:\nScaleDownDisabled false\nScaleDownDelayAfterAdd 10m\nEstimator binpacking\nExpander random\nIgnoreDaemonsetsUtilization false\nBalanceSimilarNodeGroups false\nExpendablePodsPriorityCutoff -10\nScaleDownUnneededTime 10m\n\nAuto-upgrade settings:\nEnabled false\nMaintenanceWindow.StartHour 0\nMaintenanceWindow.Day any\n\nPools:\nID Name Status Version Node Type Min Size Size Max Size Autoscaling Autohealing\n9db27bf1-bed8-4390-a8fc-d630c4da78f2 default scaling 1.17.3 dev1_m 1 1 1 false false"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking json

@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sh4d1 Sh4d1 Sh4d1 approved these changes

Assignees

@remyleone remyleone

Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When getting a k8s cluster il would like to see the pools
2 participants
@remyleone @Sh4d1