Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(printer): add support for YAML output #1308

Merged
merged 5 commits into from
Aug 25, 2020
Merged

feat(printer): add support for YAML output #1308

merged 5 commits into from
Aug 25, 2020

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@remyleone remyleone linked an issue Jul 29, 2020 that may be closed by this pull request
Having YAML as an export format #982
Closed
@remyleone remyleone marked this pull request as draft July 29, 2020 14:10
@remyleone remyleone marked this pull request as ready for review August 12, 2020 08:26
jerome-quere
jerome-quere suggested changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also should add a test

internal/core/printer.go Outdated Show resolved Hide resolved
@remyleone
Copy link
Member Author

About adding a test, would that mean adding YAML to all the goldens? just like JSON and human?

jerome-quere
jerome-quere approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 9a0e923 into scaleway:master Aug 25, 2020
@remyleone remyleone deleted the yaml branch August 25, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Having YAML as an export format
2 participants
@remyleone @jerome-quere