Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(init): add support for profile flag #1026

Merged
merged 15 commits into from
May 28, 2020
Merged

feat(init): add support for profile flag #1026

merged 15 commits into from
May 28, 2020

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@remyleone remyleone linked an issue May 25, 2020 that may be closed by this pull request
Init should handle profile flag #935
Closed
@remyleone remyleone changed the title Init profile feat(init): all usage of profile flag May 25, 2020
@remyleone remyleone marked this pull request as draft May 25, 2020 13:26
@remyleone remyleone force-pushed the init_profile branch 2 times, most recently from 504c571 to abae9a9 Compare May 26, 2020 13:56
@remyleone remyleone added the init label May 26, 2020
@remyleone remyleone self-assigned this May 27, 2020
@remyleone remyleone marked this pull request as ready for review May 27, 2020 10:06
jerome-quere
jerome-quere suggested changes May 28, 2020
View reviewed changes
internal/core/client.go Outdated Show resolved Hide resolved
internal/core/client.go Outdated Show resolved Hide resolved
@jerome-quere jerome-quere changed the title feat(init): all usage of profile flag feat(init): allow usage of profile flag May 28, 2020
@remyleone remyleone changed the title feat(init): allow usage of profile flag feat(init): add support for profile flag May 28, 2020
jerome-quere
jerome-quere approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit d9947f8 into scaleway:v2 May 28, 2020
@remyleone remyleone deleted the init_profile branch May 28, 2020 15:31
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go from 1.42.29 to 1.42.30 (s…
c700c0d 
…caleway#1026)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.42.29 to 1.42.30.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.42.29...v1.42.30)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees

@remyleone remyleone

Labels
init
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Init should handle profile flag
2 participants
@remyleone @jerome-quere