-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(baremetal): add option to add all ssh keys of an org during install #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome-quere
suggested changes
May 20, 2020
cmd/scw/testdata/test-all-usage-baremetal-server-install-usage.stderr.golden
Outdated
Show resolved
Hide resolved
internal/namespaces/baremetal/v1alpha1/custom_server_install.go
Outdated
Show resolved
Hide resolved
remyleone
force-pushed
the
baremetal_all_ssh
branch
from
May 22, 2020 09:46
2d19d67
to
d18c5c8
Compare
jerome-quere
suggested changes
May 22, 2020
internal/namespaces/baremetal/v1alpha1/custom_server_install.go
Outdated
Show resolved
Hide resolved
remyleone
force-pushed
the
baremetal_all_ssh
branch
from
May 27, 2020 13:28
c3ad568
to
a6e3cf3
Compare
jerome-quere
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
remyleone
added
the
elastic-metal
Elastic-metal issues, bugs and feature requests
label
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: