chore: add new linters (#3631)

scaleway · Feb 1, 2024 · e34c5c7 · e34c5c7
1 parent f6a0013
commit e34c5c7
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 10 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -13,7 +13,10 @@ linters:
   # Run golangci-lint linters to see the list of all linters
   # Please keep them sorted alphabetically
   enable:
+    - asasalint
+    - bidichk
     - bodyclose
+    - decorder
     - dogsled
     - errcheck
     - goconst
@@ -26,10 +29,13 @@ linters:
     - misspell
     - nakedret
     - nolintlint
+    - prealloc
+    - predeclared
     - revive
     - rowserrcheck
     - staticcheck
     - stylecheck
+    - tenv
     - typecheck
     - unconvert
     - unparam

diff --git a/internal/core/cobra_usage_builder.go b/internal/core/cobra_usage_builder.go
@@ -101,7 +101,7 @@ func _buildArgShort(as *ArgSpec) string {
 // This string will be used by cobra usage template.
 func buildExamples(binaryName string, cmd *Command) string {
 	// Build the examples array.
-	var examples []string
+	examples := make([]string, 0, len(cmd.Examples))
 
 	for _, cmdExample := range cmd.Examples {
 		// Build title.

diff --git a/internal/core/command.go b/internal/core/command.go
@@ -154,7 +154,7 @@ func (c *Command) GetUsage(binaryName string, commands *Commands) string {
 
 // seeAlsosAsStr returns all See Alsos as a single string
 func (c *Command) seeAlsosAsStr() string {
-	var seeAlsos []string
+	seeAlsos := make([]string, 0, len(c.SeeAlsos))
 
 	for _, cmdSeeAlso := range c.SeeAlsos {
 		short := fmt.Sprintf("  # %s", cmdSeeAlso.Short)

diff --git a/internal/interactive/print.go b/internal/interactive/print.go
@@ -65,9 +65,9 @@ func RemoveIndent(str string) string {
 	return strings.Trim(regexp.MustCompile("\n[ \t]*").ReplaceAllString(str, "\n"), "\n")
 }
 
-func makeStr(char string, len int) string {
+func makeStr(char string, length int) string {
 	str := ""
-	for i := 0; i < len; i++ {
+	for i := 0; i < length; i++ {
 		str += char
 	}
 	return str

diff --git a/internal/namespaces/instance/v1/custom_server.go b/internal/namespaces/instance/v1/custom_server.go
@@ -125,7 +125,8 @@ func orderVolumes(v map[string]*instance.VolumeServer) []*instance.VolumeServer
 		indexes = append(indexes, index)
 	}
 	sort.Strings(indexes)
-	var orderedVolumes []*instance.VolumeServer
+
+	orderedVolumes := make([]*instance.VolumeServer, 0, len(indexes))
 	for _, index := range indexes {
 		orderedVolumes = append(orderedVolumes, v[index])
 	}

diff --git a/internal/namespaces/object/v1/s3configfile.go b/internal/namespaces/object/v1/s3configfile.go
@@ -21,7 +21,7 @@ func (c s3tool) String() string {
 type supportedTool []s3tool
 
 func (s supportedTool) ToStringArray() []string {
-	var res []string
+	res := make([]string, 0, len(s))
 	for _, x := range s {
 		res = append(res, x.String())
 	}

diff --git a/internal/namespaces/registry/v1/custom_docker_helper.go b/internal/namespaces/registry/v1/custom_docker_helper.go
@@ -109,7 +109,7 @@ func registrySetupDockerHelperRun(ctx context.Context, argsI interface{}) (i int
 		return nil, fmt.Errorf("failed to write helper script: %s", err)
 	}
 
-	var registries []string
+	registries := make([]string, 0, len(scw.AllRegions))
 	for _, region := range scw.AllRegions {
 		registries = append(registries, getRegistryEndpoint(region))
 	}

diff --git a/internal/namespaces/registry/v1/helpers_login_logout.go b/internal/namespaces/registry/v1/helpers_login_logout.go
@@ -15,7 +15,7 @@ var (
 )
 
 func (p programs) StringArray() []string {
-	var res []string
+	res := make([]string, 0, len(p))
 	for _, prog := range p {
 		res = append(res, string(prog))
 	}

diff --git a/internal/passwordgenerator/password_generator.go b/internal/passwordgenerator/password_generator.go
@@ -74,8 +74,8 @@ func GeneratePassword(length, minNumbers, minLower, minUpper, minSymbol int) (st
 	return string(inRune), nil
 }
 
-func randInt(len int) (int, error) {
-	i, err := crypto.Int(crypto.Reader, big.NewInt(int64(len)))
+func randInt(length int) (int, error) {
+	i, err := crypto.Int(crypto.Reader, big.NewInt(int64(length)))
 	if err != nil {
 		return 0, err
 	}