chore(instance): remove support for creating a volume from a volume (#…

…3497)
scaleway · Nov 21, 2023 · acf412e · acf412e
1 parent 1c51dc2
commit acf412e
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 26 deletions.
diff --git a/cmd/scw/testdata/test-all-usage-instance-volume-create-usage.golden b/cmd/scw/testdata/test-all-usage-instance-volume-create-usage.golden
@@ -12,9 +12,6 @@ EXAMPLES:
   Create a volume with a size of 50GB
     scw instance volume create size=50GB
 
-  Create a volume of type 'l_ssd', based on volume '00112233-4455-6677-8899-aabbccddeeff'
-    scw instance volume create volume-type=l_ssd base-volume=00112233-4455-6677-8899-aabbccddeeff
-
 ARGS:
   [name=<generated>]   Volume name
   [project-id]         Project ID to use. If none is passed the default project ID will be used
@@ -25,9 +22,6 @@ ARGS:
   [organization-id]    Organization ID to use. If none is passed the default organization ID will be used
   [zone=fr-par-1]      Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3)
 
-DEPRECATED ARGS:
-  [base-volume]   ID of the volume on which this volume will be based
-
 FLAGS:
   -h, --help   help for create
 

diff --git a/docs/commands/instance.md b/docs/commands/instance.md
@@ -2913,7 +2913,6 @@ scw instance volume create [arg=value ...]
 | tags.{index} |  | Volume tags |
 | volume-type | One of: `l_ssd`, `b_ssd`, `unified`, `scratch`, `sbs_volume`, `sbs_snapshot` | Volume type |
 | size |  | Volume disk size, must be a multiple of 512 |
-| ~~base-volume~~ | Deprecated | ID of the volume on which this volume will be based |
 | base-snapshot |  | ID of the snapshot on which this volume will be based |
 | organization-id |  | Organization ID to use. If none is passed the default organization ID will be used |
 | zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `fr-par-3`, `nl-ams-1`, `nl-ams-2`, `nl-ams-3`, `pl-waw-1`, `pl-waw-2`, `pl-waw-3` | Zone to target. If none is passed will use default zone from the config |
@@ -2932,11 +2931,6 @@ Create a volume with a size of 50GB
 scw instance volume create size=50GB
 ```
 
-Create a volume of type 'l_ssd', based on volume '00112233-4455-6677-8899-aabbccddeeff'
-```
-scw instance volume create volume-type=l_ssd base-volume=00112233-4455-6677-8899-aabbccddeeff
-```
-
 
 
 

diff --git a/go.mod b/go.mod
@@ -24,7 +24,7 @@ require (
 	github.com/moby/buildkit v0.11.6
 	github.com/opencontainers/go-digest v1.0.0
 	github.com/pkg/errors v0.9.1
-	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231116153148-9180208cdea7
+	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231117155000-b7672127ea65
 	github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
 	github.com/spf13/cobra v1.8.0
 	github.com/spf13/pflag v1.0.5

diff --git a/go.sum b/go.sum
@@ -490,8 +490,8 @@ github.com/rogpeppe/go-internal v1.11.0 h1:cWPaGQEPrBb5/AsnsZesgZZ9yb1OQ+GOISoDN
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231116153148-9180208cdea7 h1:ZBmrDjGtiUGeX3HPeZ/4fcdMYnw1OnAl9ubl5e0h1nM=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231116153148-9180208cdea7/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231117155000-b7672127ea65 h1:ecI+ocsfBfEGGRPWs9pLazW2klg2G8s/JHVQzSEZoBQ=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231117155000-b7672127ea65/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
 github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
 github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
 github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=

diff --git a/internal/namespaces/instance/v1/instance_cli.go b/internal/namespaces/instance/v1/instance_cli.go
@@ -1715,13 +1715,6 @@ func instanceVolumeCreate() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
-			{
-				Name:       "base-volume",
-				Short:      `ID of the volume on which this volume will be based`,
-				Required:   false,
-				Deprecated: true,
-				Positional: false,
-			},
 			{
 				Name:       "base-snapshot",
 				Short:      `ID of the snapshot on which this volume will be based`,
@@ -1749,10 +1742,6 @@ func instanceVolumeCreate() *core.Command {
 				Short:    "Create a volume with a size of 50GB",
 				ArgsJSON: `{"size":50000000000}`,
 			},
-			{
-				Short:    "Create a volume of type 'l_ssd', based on volume '00112233-4455-6677-8899-aabbccddeeff'",
-				ArgsJSON: `{"base_volume":"00112233-4455-6677-8899-aabbccddeeff","volume_type":"l_ssd"}`,
-			},
 		},
 	}
 }