feat(serverless): add health check spec to containers (#4249)

scaleway · Oct 31, 2024 · 81af366 · 81af366
1 parent e8adef0
commit 81af366
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 0 deletions.
diff --git a/cmd/scw/testdata/test-all-usage-container-container-create-usage.golden b/cmd/scw/testdata/test-all-usage-container-container-create-usage.golden
@@ -26,6 +26,9 @@ ARGS:
   [local-storage-limit]                            Local storage limit of the container (in MB)
   [scaling-option.concurrent-requests-threshold]   
   [scaling-option.cpu-usage-threshold]             
+  [health-check.http.path]                         Path to use for the HTTP health check.
+  [health-check.failure-threshold]                 Number of consecutive health check failures before considering the container unhealthy.
+  [health-check.interval]                          Period between health checks.
   [deploy=true]                                    Deploy container after creation
   [region=fr-par]                                  Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
 

diff --git a/cmd/scw/testdata/test-all-usage-container-container-update-usage.golden b/cmd/scw/testdata/test-all-usage-container-container-update-usage.golden
@@ -26,6 +26,9 @@ ARGS:
   [local-storage-limit]                            Local storage limit of the container (in MB)
   [scaling-option.concurrent-requests-threshold]   
   [scaling-option.cpu-usage-threshold]             
+  [health-check.http.path]                         Path to use for the HTTP health check.
+  [health-check.failure-threshold]                 Number of consecutive health check failures before considering the container unhealthy.
+  [health-check.interval]                          Period between health checks.
   [region=fr-par]                                  Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
 
 DEPRECATED ARGS:

diff --git a/docs/commands/container.md b/docs/commands/container.md
@@ -81,6 +81,9 @@ scw container container create [arg=value ...]
 | local-storage-limit |  | Local storage limit of the container (in MB) |
 | scaling-option.concurrent-requests-threshold |  |  |
 | scaling-option.cpu-usage-threshold |  |  |
+| health-check.http.path |  | Path to use for the HTTP health check. |
+| health-check.failure-threshold |  | Number of consecutive health check failures before considering the container unhealthy. |
+| health-check.interval |  | Period between health checks. |
 | deploy | Default: `true` | Deploy container after creation |
 | region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
 
@@ -206,6 +209,9 @@ scw container container update <container-id ...> [arg=value ...]
 | local-storage-limit |  | Local storage limit of the container (in MB) |
 | scaling-option.concurrent-requests-threshold |  |  |
 | scaling-option.cpu-usage-threshold |  |  |
+| health-check.http.path |  | Path to use for the HTTP health check. |
+| health-check.failure-threshold |  | Number of consecutive health check failures before considering the container unhealthy. |
+| health-check.interval |  | Period between health checks. |
 | region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
 
 

diff --git a/internal/namespaces/container/v1beta1/container_cli.go b/internal/namespaces/container/v1beta1/container_cli.go
@@ -624,6 +624,27 @@ func containerContainerCreate() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
+			{
+				Name:       "health-check.http.path",
+				Short:      `Path to use for the HTTP health check.`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
+			{
+				Name:       "health-check.failure-threshold",
+				Short:      `Number of consecutive health check failures before considering the container unhealthy.`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
+			{
+				Name:       "health-check.interval",
+				Short:      `Period between health checks.`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
 			core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
 		},
 		Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {
@@ -792,6 +813,27 @@ func containerContainerUpdate() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
+			{
+				Name:       "health-check.http.path",
+				Short:      `Path to use for the HTTP health check.`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
+			{
+				Name:       "health-check.failure-threshold",
+				Short:      `Number of consecutive health check failures before considering the container unhealthy.`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
+			{
+				Name:       "health-check.interval",
+				Short:      `Period between health checks.`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
 			core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
 		},
 		Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {