feat(lb): display ipam_id for pn attachment in doc (#3924)

Co-authored-by: Rémy Léone <[email protected]>

cmd/scw/testdata/test-all-usage-lb-private-network-attach-usage.golden

@@ -8,12 +8,9 @@ USAGE:
 ARGS:
   lb-id                Load Balancer ID
   private-network-id   Private Network ID
+  [ipam-ids.{index}]   IPAM ID of a pre-reserved IP address to assign to the Load Balancer on this Private Network. In the future, it will be possible to specify multiple IPs in this field (IPv4 and IPv6), for now only one ID of an IPv4 address is expected. When null, a new private IP address is created for the Load Balancer on this Private Network.
   [zone=fr-par-1]      Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3)
 
-DEPRECATED ARGS:
-  [static-config.ip-address.{index}]   Array of a local IP address for the Load Balancer on this Private Network
-  [dhcp-config.ip-id]                  
-
 FLAGS:
   -h, --help   help for attach
 

docs/commands/lb.md

@@ -1130,8 +1130,7 @@ scw lb private-network attach <lb-id ...> [arg=value ...]
 |------|---|-------------|
 | lb-id | Required | Load Balancer ID |
 | private-network-id | Required | Private Network ID |
-| ~~static-config.ip-address.{index}~~ | Deprecated | Array of a local IP address for the Load Balancer on this Private Network |
-| ~~dhcp-config.ip-id~~ | Deprecated |  |
+| ipam-ids.{index} |  | IPAM ID of a pre-reserved IP address to assign to the Load Balancer on this Private Network. In the future, it will be possible to specify multiple IPs in this field (IPv4 and IPv6), for now only one ID of an IPv4 address is expected. When null, a new private IP address is created for the Load Balancer on this Private Network. |
 | zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `nl-ams-3`, `pl-waw-1`, `pl-waw-2`, `pl-waw-3` | Zone to target. If none is passed will use default zone from the config |
 
 

go.mod

@@ -27,7 +27,7 @@ require (
 	github.com/mattn/go-isatty v0.0.20
 	github.com/moby/buildkit v0.13.2
 	github.com/opencontainers/go-digest v1.0.0
-	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.28.0.20240626093447-0e434aaceca3
+	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.28.0.20240627133541-29fff7fd188d
 	github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
 	github.com/spf13/cobra v1.8.1
 	github.com/spf13/pflag v1.0.5

go.sum

@@ -463,8 +463,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.28.0.20240626093447-0e434aaceca3 h1:K57vK1bLYRcq5wfJfbOdysC2J0F2bpfwLCCDiIxb0Cg=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.28.0.20240626093447-0e434aaceca3/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.28.0.20240627133541-29fff7fd188d h1:CsaMtjIO39PaZINAznYmKFVh2KQU/FOvUaAuFJucXK8=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.28.0.20240627133541-29fff7fd188d/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
 github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
 github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
 github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=

internal/namespaces/lb/v1/lb_cli.go

@@ -3299,16 +3299,10 @@ func lbPrivateNetworkAttach() *core.Command {
 				Positional: false,
 			},
 			{
-				Name:       "static-config.ip-address.{index}",
-				Short:      `Array of a local IP address for the Load Balancer on this Private Network`,
+				Name:       "ipam-ids.{index}",
+				Short:      `IPAM ID of a pre-reserved IP address to assign to the Load Balancer on this Private Network. In the future, it will be possible to specify multiple IPs in this field (IPv4 and IPv6), for now only one ID of an IPv4 address is expected. When null, a new private IP address is created for the Load Balancer on this Private Network.`,
 				Required:   false,
-				Deprecated: true,
-				Positional: false,
-			},
-			{
-				Name:       "dhcp-config.ip-id",
-				Required:   false,
-				Deprecated: true,
+				Deprecated: false,
 				Positional: false,
 			},
 			core.ZoneArgSpec(scw.ZoneFrPar1, scw.ZoneFrPar2, scw.ZoneNlAms1, scw.ZoneNlAms2, scw.ZoneNlAms3, scw.ZonePlWaw1, scw.ZonePlWaw2, scw.ZonePlWaw3),