Bugfix/SK-1241 | Fix missing ROLE and TYPE in client status messages #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
fednnetwork client and combiner code, mainly focusing on updating the log level and status type handling. The most important changes include updating the log level references, adding a new status type, and modifying thesend_statusmethod to reflect these changes.Log level updates:
fedn.Statustofedn.LogLevelin multiple methods withinfedn/network/clients/client.py[1] [2] [3] [4] [5] [6] [7].fedn/network/clients/fedn_client.py[1] [2] [3] [4] [5] [6].fedn/network/clients/grpc_handler.py[1] [2] [3].fedn/network/combiner/combiner.py[1] [2].Addition of new status type:
NETWORKto theStatusTypeenum infedn/network/grpc/fedn.proto.Modifications to
send_statusmethod:send_statusmethod to use the updated log level and status type infedn/network/clients/client.py,fedn/network/clients/fedn_client.py, andfedn/network/clients/grpc_handler.py[1] [2] [3].