Feature/SK-1202 | Added log-in functionality #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklastheman
requested changes
Nov 26, 2024
fedn/cli/login_cmd.py
Outdated
| from getpass import getpass | ||
|
|
||
| # Replace this with the platform's actual login endpoint | ||
| URL = "https://fedn.scaleoutsystems.com/api/token/" |
There was a problem hiding this comment.
Cool stuff! This one should be configurable by the user. Perhaps default to https://fedn.scaleoutsystems.com (and then concat the url programatically). This is because FEDn Studio can be hosted on different domains and we would like this to work on all instances.
fedn/cli/client_cmd.py
Outdated
| except requests.exceptions.ConnectionError: | ||
| click.echo(f"Error: Could not connect to {url}") | ||
|
|
||
| @click.option("-p", "--protocol", required=False, default=CONTROLLER_DEFAULTS["protocol"], help="Communication protocol of controller (api)") |
There was a problem hiding this comment.
Why are these changes in this pr?
KatHellg
force-pushed
the
feature/SK-1202
branch
from
a80c2c8 to
b310ce6
Compare
added 11 commits
November 26, 2024 10:44
KatHellg
force-pushed
the
feature/SK-1202
branch
from
b310ce6 to
c9bacbe
Compare
Wrede
force-pushed
the
feature/SK-1202
branch
from
00b71a0 to
9d8b91d
Compare
Wrede
approved these changes
Dec 2, 2024
niklastheman
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added log-in functionality by saving access token to a context file.