Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/SK-1099 | return status code 400 if model load goes wrong and print logger.error #724

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Wrede
Copy link
Member

@Wrede Wrede commented Oct 9, 2024

This pull request includes changes to improve logging and error handling in the set_initial_model method of the fedn/network/api/interface.py file. The most important changes include adding informative log messages and modifying the error response format.

Improvements to logging:

  • Added an info log message when a model is being added. (fedn/network/api/interface.py)
  • Added an info log message to indicate which helper is being used to load the model. (fedn/network/api/interface.py)
  • Added an error log message for when an error occurs during model loading. (fedn/network/api/interface.py)

Enhancements to error handling:

  • Changed the error response to include a status code and a more detailed JSON message. (fedn/network/api/interface.py)

@Wrede Wrede merged commit 0e1781b into master Oct 10, 2024
20 checks passed
@Wrede Wrede deleted the bugfix/SK-1099 branch October 10, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants