Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/SK-1040 | Fixing numpy version with the MONAI package #705

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

mattiasakesson
Copy link
Member

@mattiasakesson mattiasakesson commented Sep 17, 2024

Description

This PR addresses the bug described in issue SK-1040, which involves fixing the numpy version compatibility with the MONAI package in the FEDn framework.

Updated the numpy version in the requirements to ensure compatibility with MONAI.
Tested the changes to confirm that the issue is resolved.

@sztoor sztoor changed the title pin numpy<2 Bug/SK-1040: Fixing numpy version with the MONAI libraries Sep 18, 2024
@sztoor sztoor changed the title Bug/SK-1040: Fixing numpy version with the MONAI libraries Bug/SK-1040: Fixing numpy version with the MONAI package Sep 18, 2024
@sztoor
Copy link
Member

sztoor commented Sep 18, 2024

This bug is related to numpy version.

Copy link
Member

@sztoor sztoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Wrede Wrede changed the title Bug/SK-1040: Fixing numpy version with the MONAI package Bug/SK-1040 | Fixing numpy version with the MONAI package Sep 23, 2024
@Wrede
Copy link
Member

Wrede commented Sep 23, 2024

Need description! Why change numpy version? What issues is being raised with latest numpy?

@Wrede Wrede added the HOLD label Sep 23, 2024
@ahellander ahellander self-requested a review September 29, 2024 19:38
Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a PR description.

@github-actions github-actions bot added the patch label Oct 1, 2024
@ahellander ahellander self-requested a review October 2, 2024 08:30
Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a PR description so we get this merged.

@ahellander ahellander merged commit 95be563 into master Oct 2, 2024
20 checks passed
@ahellander ahellander deleted the bug/SK-1040-bug-in-example-monai-2D-mednist branch October 2, 2024 08:31
@Wrede Wrede removed the HOLD label Oct 2, 2024
@mattiasakesson mattiasakesson restored the bug/SK-1040-bug-in-example-monai-2D-mednist branch October 2, 2024 18:38
@Wrede Wrede deleted the bug/SK-1040-bug-in-example-monai-2D-mednist branch October 4, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants