Docs/SK-901 | MonAI README #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so update the README file.
fix incorrect instruction regarding scaling up to 3 clients.
ahellander
approved these changes
Jun 21, 2024
Wrede
requested changes
Jun 24, 2024
| batch_size = client_settings["batch_size"] | ||
| max_epochs = client_settings["local_epochs"] | ||
| num_workers = client_settings["num_workers"] | ||
| split_index = client_settings["split_index"] | ||
| split_index = os.environ.get("FEDN_DATA_SPLIT_INDEX") #client_settings["split_index"] |
| @@ -45,7 +45,7 @@ def validate(in_model_path, out_json_path, data_path=None, client_settings_path= | |||
|
|
|||
| num_workers = client_settings["num_workers"] | |||
| batch_size = client_settings["batch_size"] | |||
| split_index = client_settings["split_index"] | |||
| split_index = os.environ.get("FEDN_DATA_SPLIT_INDEX") # client_settings["split_index"] | |||
examples/monai-2D-mednist/README.md
Outdated
| # Getting Started | ||
|
|
||
|
|
||
| For a step-by-step example guide, click [here](https://github.com/scaleoutsystems/fedn/tree/master/examples/monai-2D-mednist>). |
There was a problem hiding this comment.
this link will get you to the same README (this one)
There was a problem hiding this comment.
In FEDn MonAI example directory, we have "README.rst," which stays the same. The MonAI tutorials repository will contain "README_MonAI_Tutorial.md" in the tutorials/federated_learning/FEDn/ directory as "README.md." This file (README.md) will point to README.rst in the MonAI example directory.
examples/monai-2D-mednist/README.rst
Outdated
There was a problem hiding this comment.
Why are there 1 .md and 2 .rst files?
There was a problem hiding this comment.
I will remove .rst from the branch as in MonAI tutorials repo, they have all .md files.
added 3 commits
June 24, 2024 15:30
…ials repository. In their repo, README files are in .md format.
…ials repository. In their repo, README files are in .md format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch mainly introduces a new README file to integrate this example into the MonAI tutorial repository. To enhance user understanding, we simplified the get and load data functions. This involved code modifications and more extensive updates to the README document. Now, I have fixed the code checks as well.