Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/SK-558 | Adds Python's logging framework to the client #484

Merged
merged 12 commits into from
Nov 21, 2023
Merged

Feature/SK-558 | Adds Python's logging framework to the client #484

merged 12 commits into from
Nov 21, 2023

Conversation

stefanhellander
Copy link
Collaborator

Adds logging using Python's logging framework to the client, instead of relying on print statements. Also fixes the option to log to file. You can set the verbosity like this:

fedn run client --init client.yaml --verbosity DEBUG

Default verbosity is INFO.

Wrede
Wrede requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@Wrede Wrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! If you merge in develop into this feature branch I think you will have some regular prints that you can replace with logging as well.

ahellander
ahellander reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Would love the same in the rest of the code base as well :-)

@Wrede Wrede self-requested a review November 21, 2023 14:16
@Wrede Wrede changed the title Feature/SK-558 Feature/SK-558 | Adds logging using Python's logging framework to the client Nov 21, 2023
@Wrede Wrede changed the title Feature/SK-558 | Adds logging using Python's logging framework to the client Feature/SK-558 | AddsPython's logging framework to the client Nov 21, 2023
@Wrede Wrede changed the title Feature/SK-558 | AddsPython's logging framework to the client Feature/SK-558 | Adds Python's logging framework to the client Nov 21, 2023
@stefanhellander stefanhellander changed the base branch from develop to master November 21, 2023 14:27
@stefanhellander stefanhellander merged commit 192f3f1 into master Nov 21, 2023
15 checks passed
@stefanhellander stefanhellander deleted the feature/SK-558 branch November 21, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahellander ahellander ahellander left review comments

@Wrede Wrede Wrede approved these changes

@niklastheman niklastheman Awaiting requested review from niklastheman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanhellander @ahellander @Wrede