Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #356 #357

Merged
merged 18 commits into from
Mar 1, 2022
Merged

Resolves #356 #357

merged 18 commits into from
Mar 1, 2022

Conversation

ahellander
Copy link
Member

Status

  • Ready
  • Draft
  • Hold

Description

Describe your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to include a link to that issue.

Types of changes

What types of changes does your code introduce to FEDn?

  • Hotfix (fixing a critical bug in production)
  • Bugfix
  • New feature
  • Documentation update

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have read the CONTRIBUTING doc
  • I have included tests to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request

Further comments

Anything else you think we should know before merging your code!

@ahellander ahellander added the bugfix Something isn't working label Feb 28, 2022
@ahellander ahellander self-assigned this Feb 28, 2022
@ahellander ahellander linked an issue Feb 28, 2022 that may be closed by this pull request
4 tasks
@mcapuccini mcapuccini merged commit 336d201 into develop Mar 1, 2022
@mcapuccini mcapuccini deleted the BUGFIX/GH-356 branch March 1, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninitialized variable if first heartbeat fails
2 participants