Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incrementhelper in kerashelper is incorrect #492

Closed
3 tasks
mattiasakesson opened this issue Dec 5, 2023 · 0 comments · Fixed by #493
Closed
3 tasks

incrementhelper in kerashelper is incorrect #492

mattiasakesson opened this issue Dec 5, 2023 · 0 comments · Fixed by #493

Comments

@mattiasakesson
Copy link
Member

Severity

  • Critical/Blocker (select if the issue makes the application unusable or causes serious data loss)
  • [ x] High (select if the issue affects a major feature and there is no workaround or the available workaround is very complex)
  • Medium (select if the issue affects a minor feature or affects a major feature but has an easy enough workaround to not cause any major inconvenience)
  • Low (select if the issue doesn't significantly affect the user experience, like minor visual bugs)

Describe the bug
A clear and concise description of what the bug is.
The bug calculate the weights contribution incorrectly

Environment:

  • OS: [e.g. mac OS]
  • Version: [e.g. macOS Catalina]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Reproduction Steps
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error
    create 2 client, one with metadata num_examples=0 and the other one with a positive integer, the global model update will then be the one with num_examples=0.

Expected behavior
A clear and concise description of what you expected to happen.
Incorrect model contribution

Screenshots
If applicable, add screenshots to help explain your problem.

Contact Details
An e-mail address in case we need to contact you for further details regarding this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant