Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add allow_destroy_plan and auto_apply flags for workspaces #8

Merged
merged 1 commit into from
Feb 22, 2023
Merged

feat: add allow_destroy_plan and auto_apply flags for workspaces #8

merged 1 commit into from
Feb 22, 2023

Conversation

jpetrucciani
Copy link
Contributor

This PR just adds a couple more options, defaulting to their current state in the module!

mbevc1
mbevc1 previously approved these changes Feb 22, 2023
Copy link
Member

@mbevc1 mbevc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍

@mbevc1 mbevc1 added the enhancement New feature or request label Feb 22, 2023
@mbevc1
Copy link
Member

mbevc1 commented Feb 22, 2023

Would you mind pushing an empty request to trigger checkes please?

mbevc1
mbevc1 previously approved these changes Feb 22, 2023
@mbevc1
Copy link
Member

mbevc1 commented Feb 22, 2023

huh, need to check branch protections why this is not starting here...

@mbevc1
Copy link
Member

mbevc1 commented Feb 22, 2023

Seems like it was filtering only on this repo branches. Could you please try rebasing and pushing please?

@jpetrucciani
Copy link
Contributor Author

sure, just a min!

@jpetrucciani
Copy link
Contributor Author

@mbevc1 should be good to run workflows on now! rebased off of latest from main - should be just the new commit there now

@mbevc1
Copy link
Member

mbevc1 commented Feb 22, 2023

Perfect, thanks again! Looks good now 👍

@mbevc1 mbevc1 merged commit 0551bfb into scalefactory:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants