Get rid of dependency on environment variables in public configuration #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome via config properties setter methods (initialization from ENV variables remained as default option).
segabriel
reviewed
May 30, 2020
config-vault/src/main/java/io/scalecube/config/vault/VaultConfigSource.java
Outdated
Show resolved
Hide resolved
io-scalecube-ci
added a commit
that referenced
this pull request
May 30, 2020
Get rid of dependency on environment variables in public configuration [skip ci] prepare release v0.4.4-RC2
io-scalecube-ci
added a commit
that referenced
this pull request
May 30, 2020
Get rid of dependency on environment variables in public configuration [skip ci] prepare for next development iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Design of a component configuration via ENV variables and not via normal property setters -- is bad design.
Updates
Made settings to come via config properties setter methods (initialization from ENV variables remained as default option). Get rid of
MockEnviro..Variabl...Loderin the test code.