Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of address #394

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Get rid of address #394

merged 2 commits into from
Sep 23, 2024

Conversation

artem-v
Copy link
Contributor

@artem-v artem-v commented Sep 22, 2024

No description provided.

@artem-v artem-v requested a review from matyasberry September 22, 2024 14:30
matyasberry
matyasberry reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@matyasberry matyasberry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see we traded a reference in a POJO that's in a rather slim jar for String parsing. What are the benefits that we aim to achieve?

...rt-parent/transport-api/src/main/java/io/scalecube/cluster/transport/api/DistinctErrors.java Show resolved Hide resolved
matyasberry
matyasberry requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@matyasberry matyasberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need test for DistinctErrors, but otherwise ok.

@artem-v
Copy link
Contributor Author

artem-v commented Sep 23, 2024

As I see we traded a reference in a POJO that's in a rather slim jar for String parsing. What are the benefits that we aim to achieve?

Main benefit - get rid of inter-module dependencies between scalecube repositories, and make them as independent as possible, and with as less dependencies as possible.

@artem-v artem-v merged commit 270366f into master Sep 23, 2024
1 check passed
@artem-v artem-v deleted the get-rid-of-address-carefully branch September 23, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasberry matyasberry matyasberry requested changes

@segabriel segabriel segabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem-v @segabriel @matyasberry