[not for merge] Update to fastparse 2 (#510) #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
commented
Jan 31, 2019
| val ValueArray: P[TValue] = | ||
| P((Index ~ "[" ~/ (PrimitiveValue | MessageValue).rep(0, ",".~/) ~/ "]")).map(TArray.tupled) | ||
| def ValueArray[_: P]: P[TValue] = | ||
| P((Index ~ "[" ~/ (PrimitiveValue | MessageValue).rep(0, ",") ~/ "]")).map(TArray.tupled) |
There was a problem hiding this comment.
I'm not sure the .~/ was meaningful here?
| @@ -1,48 +1,37 @@ | |||
| package scalapb.textformat | |||
|
|
|||
| import fastparse.WhitespaceApi | |||
| import fastparse._ | |||
| import fastparse.ScriptWhitespace._ | |||
There was a problem hiding this comment.
I'm not entirely sure this correctly corresponds to Basics.whiteSpace
Disabled 'native' targets for now since fastparse 2 has not been released for Scala Native yet.
As I don't think it is supposed to be part of the public API?
raboof
force-pushed
the
updateToFastparse2
branch
from
e977285 to
4b8138d
Compare
|
this appears to have been merged in some form...? |
|
Looks like 👍! |
|
Yes, thanks again for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #510.
I had to disable the 'native' build targets for now since fastparse 2 has not been released for Scala Native yet, see com-lihaoyi/fastparse#215.