replace lazy vals in size generation with explicit lazy initialization #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazy vals are replaced by transient backing fields with -1 as sentinel value and lazy initialization in accessor methods The best low hanging fruit for scalapb#116 right now. Motivation for the fix is described in the scalapb#116
|
Merged - thank you for looking into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lazy vals are replaced by transient backing fields with -1 as sentinel value
and lazy initialization in accessor methods
The best low hanging fruit for #116 right now.
Motivation for the fix is described in the same #116