Add companion_extends #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this. It looks good overall, except that the autogenerated Java file seem to have been generated with a different version of protoc. Can you use the latest protoc, protoc 3.0.0-beta2, to generate them? Also, there's a script called make_plugin_proto.sh which you can use at the root directory. |
trungfinity
force-pushed
the
companion-extends
branch
from
1abec97 to
b52e9fd
Compare
|
Updated! protoc 3.0.0-beta2 is used now. |
|
Merged - thanks for contributing this. |
|
Could you publish a new version of ScalaPB? Or do you have any ETA for it? |
|
👍 on a new release |
|
Yes - released 0.5.26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would fix #105. Please help me review, thanks.