Modification: consistency, rename isNewline->isNL

scalafmt-core/shared/src/main/scala/org/scalafmt/internal/FormatOps.scala

@@ -676,7 +676,7 @@ class FormatOps(
       }
       val nlMod = newStmtMod
         .getOrElse(Space.orNL(ft.noBreak && ft.right.is[T.Comment]))
-      val delayedBreak = Policy ? nlMod.isNewline || breakAfterComment(ft)
+      val delayedBreak = Policy ? nlMod.isNL || breakAfterComment(ft)
 
       val (singleLineExpire, singleLineIndent) = {
         val skip = skipInfixIndent

scalafmt-core/shared/src/main/scala/org/scalafmt/internal/FormatWriter.scala

@@ -1191,7 +1191,7 @@ class FormatWriter(formatOps: FormatOps) {
           }
 
           implicit val floc: FormatLocation = processLine
-          val isBlankLine = floc.state.split.modExt.mod.newlines > 1
+          val isBlankLine = floc.state.split.modExt.mod.isBlankLine
           if (alignContainer ne null) {
             val candidates = columnCandidates.result()
             val block = getOrCreateBlock(alignContainer)

scalafmt-core/shared/src/main/scala/org/scalafmt/internal/ModExt.scala

@@ -13,7 +13,7 @@ case class ModExt(mod: Modification, indents: Seq[Indent] = Seq.empty) {
   lazy val indentation = indents.mkString("[", ", ", "]")
 
   @inline
-  def isNL: Boolean = mod.isNewline
+  def isNL: Boolean = mod.isNL
 
   def withIndent(length: => Length, expire: => Token, when: ExpiresOn): ModExt =
     length match {

scalafmt-core/shared/src/main/scala/org/scalafmt/internal/Modification.scala

@@ -4,13 +4,15 @@ sealed abstract class Modification {
   val newlines: Int
   val length: Int
   @inline
-  final def isNewline: Boolean = newlines != 0
+  final def isNL: Boolean = newlines != 0
+  @inline
+  final def isBlankLine: Boolean = newlines > 1
 }
 
 case class Provided(ft: FormatToken) extends Modification {
   override val newlines: Int = ft.newlinesBetween
   override lazy val length: Int =
-    if (newlines == 0) betweenText.length else betweenText.indexOf('\n')
+    if (isNL) betweenText.indexOf('\n') else betweenText.length
   lazy val betweenText: String = ft.between.map(_.syntax).mkString
 }
 

scalafmt-core/shared/src/main/scala/org/scalafmt/internal/Router.scala

@@ -1885,7 +1885,7 @@ class Router(formatOps: FormatOps) {
         val mod =
           if (style.newlines.keepBreak(newlines)) Newline
           else Space(style.spaces.isSpaceAfterKeyword(right))
-        val slb = Split(mod.isNewline, 0)(mod)
+        val slb = Split(mod.isNL, 0)(mod)
           .withSingleLine(expire, killOnFail = true)
         val mlSplitBase = Split(mod, if (slb.isIgnored) 0 else 1)
           .withPolicy(getBreakBeforeElsePolicy(owner))

scalafmt-core/shared/src/main/scala/org/scalafmt/internal/State.scala

@@ -75,7 +75,7 @@ final case class State(
     // Some tokens contain newline, like multiline strings/comments.
     val startColumn = nextSplit.modExt.mod match {
       case m: NewlineT => if (m.noIndent) 0 else nextIndent
-      case m => if (m.isNewline) nextIndent else column + m.length
+      case m => if (m.isNL) nextIndent else column + m.length
     }
     val (columnOnCurrentLine, nextStateColumn) = State
       .getColumns(tok, nextIndent, startColumn)