Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RewriteTrailingCommas: handle optional braces case #4059

Merged
merged 2 commits into from
Jun 17, 2024
Merged

RewriteTrailingCommas: handle optional braces case #4059

merged 2 commits into from
Jun 17, 2024

Commits on Jun 17, 2024

  1. Test non-idempotent optional-braces trailing comma

    @kitbellew
    kitbellew committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    dc8757f View commit details
    Browse the repository at this point in the history

  2. RewriteTrailingCommas: handle optional braces case 

    Don't check equality of owners of comma and closing delimiter, it's no
longer guaranteed. Also, inconsistent with the check in FormatWriter so
that could lead to further non-idempotency.
    @kitbellew
    kitbellew committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    c5f44f2 View commit details
    Browse the repository at this point in the history