ConvertToNewScala3Syntax: use the new granular parameter #3735
Conversation
kitbellew
force-pushed
the
3732
branch
2 times, most recently
from
f4e22be
to
ab73a5c
Compare
|
Do we really need this to be that granular? Maybe it's enough to have separate changes for optional braces and separate for things that are not affected by it? |
|
@tgodzik i thought about it. looked at braces rewrite which has over time become rather granular, same for indent which had originally been declared inviolate and fixed, and decided to avoid further requests 🙂 |
I think in this case we should not allow to have different if and when convention. But it's up to you, I don't think it would ever make sense and it would be valid to close any such request as not planned. |
|
@tgodzik agreed, let's merge |
|
also, since i am not a big expert on backports to scala213 (via |
| ifCond: Boolean = true, | ||
| whileCond: Boolean = true, | ||
| forEnum: Boolean = true, |
There was a problem hiding this comment.
| ifCond: Boolean = true, | |
| whileCond: Boolean = true, | |
| forEnum: Boolean = true, | |
| optionalBraces = true |
| varargStar: Boolean = true, | ||
| importStar: Boolean = true, | ||
| importAs: Boolean = true, | ||
| typeWildcardQuestionMark: Boolean = true, | ||
| typePlaceholderUnderscore: Boolean = true |
There was a problem hiding this comment.
| varargStar: Boolean = true, | |
| importStar: Boolean = true, | |
| importAs: Boolean = true, | |
| typeWildcardQuestionMark: Boolean = true, | |
| typePlaceholderUnderscore: Boolean = true | |
| deprecatedSyntax = true |
maybe? This would be controlled by the dialect to see if the new syntax is allowed.
Otherwise if only one thing is set then the user will be quite confused. The separate non optional braces (traditional braced if etc.) will probably not be deprecated ever,.
|
@tgodzik all done |
Supersedes #3732.